Re: [PATCH] integrity: get comm using lock to avoid race in string printing

On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: > On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: > > Hello Mimi, > > > > On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: > > > This change is already being upstreamed as commit 73a6b44 "Integrity: > > > Pass commname via get_task_comm()". > > > > While I was looking at Richard's patch, I noticed a few places where cause and > > op are logged and the string isn't tied together with a _ or -. These are in > > ima/ima_appraise.c line 383, and ima/ima_policy.c lines 333, 657, and 683. Are > > these fixed upstream? Or should a patch be made? > > Nothing has changed in terms of 'cause' and 'op'. I would suggest > making the changes in integrity_audit.c: integrity_audit_msg(). The question is actually, do you know of anyone who is expecting the space, instead of a more 'audit standard' - or _ ? If not, we'll change it. If so, we'll discuss more :)