8:03 p.m.
On Mon, 11 Sep 2006 18:37:49 +0100
Al Viro <viro(a)ftp.linux.org.uk> wrote:
Audit fixes and missing bits; compared to the last attempt there are
two added
fixes from Amy... Please, pull:
git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current.git/ audit.b28
This seems a bit.... late.
The patch adds a whole bunch of new extern-decls-in-C. It'd be nice to get
those into a header file sometime.
And sparc64 allmodconfig broke.
kernel/built-in.o(.text+0x36834): In function `audit_filter_rules':
: undefined reference to `audit_classify_syscall'
make: *** [.tmp_vmlinux1] Error 1
Possibly because the audit git tree fell out of -mm ages ago, partly
because its owner (ahem) ignored my request to resync it with upstream. I
have new scripts from Junio and shall try again.
2:14 a.m.
New subject: [git pull] audit updates and fixes
Duh... Two trivial fixes:
* make sure that all non-biarch targets get hookup.
* deal with sparc64 correctly.
[ObGit: git-diff after git-mv + modify a couple of lines generates
deletion+new file instead of rename. Weird...]
Please, pull from
git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current.git/ audit.b29
Al Viro:
syscall class hookup for all normal targets
sparc64 audit syscall classes hookup
arch/i386/kernel/audit.c | 51 ---------------------------
b/arch/i386/kernel/Makefile | 1
b/arch/ia64/Kconfig | 4 ++
b/arch/powerpc/Kconfig | 4 ++
b/arch/s390/Kconfig | 4 ++
b/arch/sparc64/Kconfig | 4 ++
b/arch/sparc64/kernel/Makefile | 3 +
b/arch/sparc64/kernel/audit.c | 66 +++++++++++++++++++++++++++++++++++
b/arch/sparc64/kernel/compat_audit.c | 37 +++++++++++++++++++
b/arch/x86_64/Kconfig | 4 ++
b/lib/Kconfig | 5 ++
b/lib/Makefile | 1
b/lib/audit.c | 53 ++++++++++++++++++++++++++++
13 files changed, 185 insertions(+), 52 deletions(-)
7:36 p.m.
New subject: [git pull] audit updates and fixes
On Tue, 12 Sep 2006, Al Viro wrote:
[ObGit: git-diff after git-mv + modify a couple of lines generates
deletion+new file instead of rename. Weird...]
No it doesn't.
Are you sure you used the "-M" flag to ask for renames?
The other alternative is that the file was so small that the change is
considered significant, and it becomes a rewrite.
Linus
7:39 p.m.
New subject: [git pull] audit updates and fixes
On Tue, 12 Sep 2006, Al Viro wrote:
arch/i386/kernel/audit.c | 51 ---------------------------
b/arch/i386/kernel/Makefile | 1
b/arch/ia64/Kconfig | 4 ++
b/arch/powerpc/Kconfig | 4 ++
b/arch/s390/Kconfig | 4 ++
b/arch/sparc64/Kconfig | 4 ++
b/arch/sparc64/kernel/Makefile | 3 +
b/arch/sparc64/kernel/audit.c | 66 +++++++++++++++++++++++++++++++++++
b/arch/sparc64/kernel/compat_audit.c | 37 +++++++++++++++++++
b/arch/x86_64/Kconfig | 4 ++
b/lib/Kconfig | 5 ++
b/lib/Makefile | 1
b/lib/audit.c | 53 ++++++++++++++++++++++++++++
13 files changed, 185 insertions(+), 52 deletions(-)
Btw, if you do "git diff --stat --summary -M", you'd have gotten
arch/i386/kernel/Makefile | 1 -
arch/ia64/Kconfig | 4 ++
arch/powerpc/Kconfig | 4 ++
arch/s390/Kconfig | 4 ++
arch/sparc64/Kconfig | 4 ++
arch/sparc64/kernel/Makefile | 3 ++
arch/sparc64/kernel/audit.c | 66 ++++++++++++++++++++++++++++++++++++
arch/sparc64/kernel/compat_audit.c | 37 ++++++++++++++++++++
arch/x86_64/Kconfig | 4 ++
lib/Kconfig | 5 +++
lib/Makefile | 1 +
{arch/i386/kernel => lib}/audit.c | 2 +
12 files changed, 134 insertions(+), 1 deletions(-)
create mode 100644 arch/sparc64/kernel/audit.c
create mode 100644 arch/sparc64/kernel/compat_audit.c
rename arch/i386/kernel/audit.c => lib/audit.c (97%)
instead, which is much nicer. It shows the rename, and the summary info
also points out that some of the files were newly created.
Linus
8:17 p.m.
New subject: [git pull] audit updates and fixes
On Tue, Sep 12, 2006 at 05:39:08PM -0700, Linus Torvalds wrote:
> arch/i386/kernel/audit.c | 51
---------------------------
> b/arch/i386/kernel/Makefile | 1
> b/arch/ia64/Kconfig | 4 ++
> b/arch/powerpc/Kconfig | 4 ++
> b/arch/s390/Kconfig | 4 ++
> b/arch/sparc64/Kconfig | 4 ++
> b/arch/sparc64/kernel/Makefile | 3 +
> b/arch/sparc64/kernel/audit.c | 66 +++++++++++++++++++++++++++++++++++
> b/arch/sparc64/kernel/compat_audit.c | 37 +++++++++++++++++++
> b/arch/x86_64/Kconfig | 4 ++
> b/lib/Kconfig | 5 ++
> b/lib/Makefile | 1
> b/lib/audit.c | 53 ++++++++++++++++++++++++++++
> 13 files changed, 185 insertions(+), 52 deletions(-)
Btw, if you do "git diff --stat --summary -M", you'd have gotten
arch/i386/kernel/Makefile | 1 -
arch/ia64/Kconfig | 4 ++
arch/powerpc/Kconfig | 4 ++
arch/s390/Kconfig | 4 ++
arch/sparc64/Kconfig | 4 ++
arch/sparc64/kernel/Makefile | 3 ++
arch/sparc64/kernel/audit.c | 66 ++++++++++++++++++++++++++++++++++++
arch/sparc64/kernel/compat_audit.c | 37 ++++++++++++++++++++
arch/x86_64/Kconfig | 4 ++
lib/Kconfig | 5 +++
lib/Makefile | 1 +
{arch/i386/kernel => lib}/audit.c | 2 +
12 files changed, 134 insertions(+), 1 deletions(-)
create mode 100644 arch/sparc64/kernel/audit.c
create mode 100644 arch/sparc64/kernel/compat_audit.c
rename arch/i386/kernel/audit.c => lib/audit.c (97%)
instead, which is much nicer. It shows the rename, and the summary info
also points out that some of the files were newly created.
I see... FWIW, I'd been using git diff fed through diffstat(1) for that
part. Thanks, that's indeed much better.
ObMIPS: how many ABI do we have there, anyway? 4 + IRIX compat? More?
6488
days inactive
6489
days old
linux-audit@lists.linux-audit.osci.io
4 comments
3 participants
participants (3)
-
Al Viro -
Andrew Morton -
Linus Torvalds