On Fri, Dec 11, 2020 at 10:33 AM Richard Guy Briggs <rgb(a)redhat.com&gt; wrote: Yes, thanks for catching this and submitting a patch. However, as it came very late in the v5.10-rcX release cycle I'm going to wait until after this merge window to merge it into audit/next. Because it is legal; odd, but legal. :) The comma operator allows multiple expressions to be executed with only the last expression returned. Take the example below: % cat test.c #include <stdlib.h> #include <stdio.h> int main(int argc, char *argv[]) { int a, b, c; a = (b = 1, c = 2); printf("a = %d, b = %d, c = %d\n", a, b, c); return 0; } % gcc -o test test.c % ./test a = 2, b = 1, c = 2 ... we see both "b=1" and "c=2" are executed, and the last statement in the comma separated list of expressions is used as the right-hand value in the "a" assignment. In the case of this patch, the existing code is actually okay: both expressions are executed and we don't assign either expression's value to a variable so it doesn't matter. However, it definitely looks odd and is something we should fix. -- paul moore www.paul-moore.com