Hello, Thanks for the comments. ----- "Eric Paris" <eparis(a)redhat.com&gt; wrote: Fixed all of these. The callers ensure that the inputs are trusted, but I did have untrusted input there at least once, so it is indeed safer. Attached is an updated patch; in addition to the above changes, it also splits struct audit_crypto_op to three to avoid an union, making the code easier to read and more similar to other auxiliary data structures in auditsc.c. Mirek