Re: [PATCH] Don't crash on unknown S_IFMT file modes
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
----- "LC Bruzenak" <lenny(a)magitekltd.com> wrote:
Thank you for this patch...wherever it may be.
:)
Ooops :/
Do you have a standard auparse test you use to track these down?
No, I only have a small Python program to use auparse to interpret a supplied log
file (attached). There is also (make check).
Mirek
Attachments:
- audit-ifmt.patch (application/octet-stream — 2.1 KB)
- audit-interpret.py (application/octet-stream — 1.4 KB)
Friday, 27 March
Fri, 27 Mar
10:44 a.m.
New subject: [PATCH] Don't crash on unknown S_IFMT file modes
Mirek,
After applying this patch my build fails in the parse test section due
to a difference of no space after a comma:
diff -u ../../auparse/test/auparse_test.ref auparse_test.cur
--- ../../auparse/test/auparse_test.ref 2009-02-24 15:11:35.000000000
-0600
+++ auparse_test.cur 2009-03-27 10:21:34.000000000 -0500
...
- mode=040730 (dir, 730)
+ mode=040730 (dir,730)
I have made some local changes myself but I don't think it is me (which
of course probably means it IS).
Do you think your changes would cause this?
Thx,
LCB.
--
LC (Lenny) Bruzenak
lenny(a)magitekltd.com
----- "LC Bruzenak" <lenny(a)magitekltd.com> wrote:
After applying this patch my build fails in the parse test section
due
to a difference of no space after a comma:
- mode=040730 (dir, 730)
+ mode=040730 (dir,730)
Do you think your changes would cause this?
Yes, that change was intentional and
documented in the patch. I forgot to run (make check) and update the test case.
Mirek
On Fri, 2009-03-27 at 10:44 -0500, LC Bruzenak wrote:
Mirek,
After applying this patch my build fails in the parse test section due
to a difference of no space after a comma:
diff -u ../../auparse/test/auparse_test.ref auparse_test.cur
--- ../../auparse/test/auparse_test.ref 2009-02-24 15:11:35.000000000
-0600
+++ auparse_test.cur 2009-03-27 10:21:34.000000000 -0500
...
- mode=040730 (dir, 730)
+ mode=040730 (dir,730)
I have made some local changes myself but I don't think it is me (which
of course probably means it IS).
Do you think your changes would cause this?
Thx,
LCB.
This change fixed it for me - adding a space. You likely want to apply
the same fix, or if you like this formatting, change the checked
reference output.
// and the read, write, execute flags in octal
- asprintf(&out, "%s %03o", buf, (S_IRWXU|S_IRWXG|S_IRWXO) &
ival);
+ asprintf(&out, "%s, %03o", buf, (S_IRWXU|S_IRWXG|S_IRWXO) &
ival);
--
LC (Lenny) Bruzenak
lenny(a)magitekltd.com
5748
days inactive
5749
days old
linux-audit@lists.linux-audit.osci.io
3 comments
2 participants
tags (0)
participants (2)
-
LC Bruzenak -
Miloslav Trmac