Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports
On Thu, Apr 20, 2006 at 02:25:19PM -0700, Tony Jones wrote:
On Thu, Apr 20, 2006 at 11:05:21PM +0200, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL's:
> - audit_log_start
> - audit_log_end
> - audit_log_format
> - audit_log
>
> Signed-off-by: Adrian Bunk <bunk(a)stusta.de>
>
> --- linux-2.6.17-rc1-mm3-full/kernel/audit.c.old 2006-04-20 22:38:17.000000000
+0200
> +++ linux-2.6.17-rc1-mm3-full/kernel/audit.c 2006-04-20 22:40:03.000000000 +0200
> @@ -1092,7 +1092,3 @@
> }
> }
>
> -EXPORT_SYMBOL(audit_log_start);
> -EXPORT_SYMBOL(audit_log_end);
> -EXPORT_SYMBOL(audit_log_format);
> -EXPORT_SYMBOL(audit_log);
It would seem useful to allow out of tree modules (even if they never have
a goal of submitting to become intree) to log audit data. No? A reason to
prevent it seems utterly lost on me.
Out of tree modules without the goal of being submitted are not a good
idea.
AppArmor/LSM is a good example what can happen if people don't submit
their external modules for inclusion in the kernel.
Tony
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed