Re: [nf PATCH 1/2] netfilter: nf_tables: Audit log setelem reset
On Wed, Aug 30, 2023 at 4:54 PM Richard Guy Briggs <rgb(a)redhat.com> wrote:
On 2023-08-30 17:46, Pablo Neira Ayuso wrote:
> On Tue, Aug 29, 2023 at 07:51:57PM +0200, Phil Sutter wrote:
> > Since set element reset is not integrated into nf_tables' transaction
> > logic, an explicit log call is needed, similar to NFT_MSG_GETOBJ_RESET
> > handling.
> >
> > For the sake of simplicity, catchall element reset will always generate
> > a dedicated log entry. This relieves nf_tables_dump_set() from having to
> > adjust the logged element count depending on whether a catchall element
> > was found or not.
>
> Applied, thanks Phil
Thanks Phil, Pablo. If it isn't too late, please add my
Reviewed-by: Richard Guy Briggs <rgb(a)redhat.com>
Similarly, you can add my ACK. FWIW, if you're sending patches out
during the first few days of the merge window it might be advisable to
wait more than a day or two to give the relevant maintainers a chance
to review the patch.
Also, as a note for future submissions, we've moved the audit kernel
mailing list to audit(a)vger.kernel.org.
Acked-by: Paul Moore <paul(a)paul-moore.com>
--
paul-moore.com