Re: [PATCH ghak81 RFC V1 4/5] audit: use inline function to set audit context

On Fri, May 04, 2018 at 04:54:37PM -0400, Richard Guy Briggs wrote: > Recognizing that the audit context is an internal audit value, use an > access function to set the audit context pointer for the task > rather than reaching directly into the task struct to set it. > > Signed-off-by: Richard Guy Briggs <rgb(a)redhat.com&gt; > --- > include/linux/audit.h | 8 ++++++++ > kernel/auditsc.c | 6 +++--- > kernel/fork.c | 2 +- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/include/linux/audit.h b/include/linux/audit.h > index 93e4c61..dba0d45 100644 > --- a/include/linux/audit.h > +++ b/include/linux/audit.h > @@ -235,6 +235,10 @@ extern void __audit_inode_child(struct inode *parent, > extern void __audit_seccomp(unsigned long syscall, long signr, int code); > extern void __audit_ptrace(struct task_struct *t); > > +static inline void audit_set_context(struct task_struct *task, struct audit_context *ctx) > +{ > + task->audit_context = ctx; > +} > static inline struct audit_context *audit_context(struct task_struct *task) > { > return task->audit_context; > @@ -472,6 +476,10 @@ static inline bool audit_dummy_context(void) > { > return true; > } > +static inline void audit_set_context(struct task_struct *task, struct audit_context *ctx) > +{ > + task->audit_context = ctx; > +} If audit_context is an internal audit value why do we set it when CONFIG_AUDITSYSCALL is not set?

Tobin.