Re: [PATCH ghak25 v2 1/9] netfilter: normalize x_table function declarations
On 2020-01-08 17:47, Nicolas Dichtel wrote:
Le 06/01/2020 à 19:54, Richard Guy Briggs a écrit :
> Git context diffs were being produced with unhelpful declaration types
> in the place of function names to help identify the funciton in which
> changes were made.
Just for my information, how do you reproduce that? With a 'git diff'?
git format-patch is how it is presenting as a problem, which I assume
would also be git diff.
> Normalize x_table function declarations so that git context
diff
> function labels work as expected.
>
[snip]
>
> --
> 1.8.3.1
git v1.8.3.1 is seven years old:
https://github.com/git/git/releases/tag/v1.8.3.1
I don't see any problems with git v2.24. Not sure that the patch brings any
helpful value except complicating backports.
It brings value to anyone who is on a distro that is stable and only
slightly behind. There are other features of git 2.x that I'd like to
start using (git worktrees) but I'll have to wait until I can afford to
upgrade.
Nicolas
- RGB
--
Richard Guy Briggs <rgb(a)redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635