Re: [PATCH V6 07/10] sched: add a macro to ref all CLONE_NEW* flags

On 15/04/17, Peter Zijlstra wrote: > On Fri, Apr 17, 2015 at 03:35:54AM -0400, Richard Guy Briggs wrote: > > Added the macro CLONE_NEW_MASK_ALL to refer to all CLONE_NEW* flags. > > A wee bit about why might be nice.. It makes the following patch much cleaner to read: [PATCH V6 08/10] fork: audit on creation of new namespace(s) https://lkml.org/lkml/2015/4/17/50 I was hoping it might also make a lot of other code cleaner, but most of the other places where multiple CLONE_NEW* flags are used, not all six are used together, but only 5 are used. Ok, so it is helpful in 1 of 3: It would actually be useful in check_unshare_flags(): https://github.com/torvalds/linux/blob/v3.17/kernel/fork.c#L1791 but not in copy_namespaces() or unshare_nsproxy_namespaces(): https://github.com/torvalds/linux/blob/v3.17/kernel/nsproxy.c#L130 https://github.com/torvalds/linux/blob/v3.17/kernel/nsproxy.c#L183