5:33 a.m.
Hi Casey,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf/master]
[also build test WARNING on linus/master v5.13-rc6]
[cannot apply to security/next-testing pcmoore-audit/next nf-next/master next-20210615]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Infrastructu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/d534cd725d8e262f150ea8c62bd452ae6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254
git checkout d534cd725d8e262f150ea8c62bd452ae6d42bb19
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from kernel/audit.c:51:
include/linux/audit.h:571:1: error: expected identifier or '(' before
'+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
kernel/audit.c: In function 'audit_log_config_change':
kernel/audit.c:393:12: error: implicit declaration of function
'audit_alloc_for_lsm'; did you mean 'audit_alloc_mark'?
[-Werror=implicit-function-declaration]
393 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_alloc_mark
> kernel/audit.c:393:10: warning: assignment to 'struct
audit_context *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
393 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: In function 'audit_receive_msg':
kernel/audit.c:1358:13: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
1358 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1381:13: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
1381 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1399:12: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
1399 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1431:12: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
1431 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c:1505:12: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
1505 | lcontext = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: In function 'audit_log_multicast':
kernel/audit.c:1567:10: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
1567 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
kernel/audit.c: At top level:
kernel/audit.c:1789:14: warning: no previous prototype for 'audit_serial'
[-Wmissing-prototypes]
1789 | unsigned int audit_serial(void)
| ^~~~~~~~~~~~
kernel/audit.c: In function 'audit_log_vformat':
kernel/audit.c:1937:2: warning: function 'audit_log_vformat' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1937 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args);
| ^~~
kernel/audit.c:1946:3: warning: function 'audit_log_vformat' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1946 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2);
| ^~~
kernel/audit.c: In function 'audit_log_set_loginuid':
kernel/audit.c:2334:10: warning: assignment to 'struct audit_context *' from
'int' makes pointer from integer without a cast [-Wint-conversion]
2334 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
In file included from include/linux/perf_event.h:25,
from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:87,
from kernel/audit.c:44:
At top level:
arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined
but not used [-Wunused-const-variable=]
126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
| ^~~~~~~~~~~~~~~~~
arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined
but not used [-Wunused-const-variable=]
91 | static const char * const arc_pmu_ev_hw_map[] = {
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from kernel/auditfilter.c:12:
include/linux/audit.h:571:1: error: expected identifier or '(' before
'+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
kernel/auditfilter.c: In function 'audit_log_rule_change':
kernel/auditfilter.c:1107:12: error: implicit declaration of function
'audit_alloc_for_lsm'; did you mean 'audit_alloc_mark'?
[-Werror=implicit-function-declaration]
1107 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_alloc_mark
> kernel/auditfilter.c:1107:10: warning: assignment to 'struct
audit_context *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
1107 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
--
In file included from security/integrity/integrity_audit.c:12:
include/linux/audit.h:571:1: error: expected identifier or '(' before
'+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
security/integrity/integrity_audit.c: In function 'integrity_audit_message':
security/integrity/integrity_audit.c:48:12: error: implicit declaration of function
'audit_alloc_for_lsm'; did you mean 'audit_log_format'?
[-Werror=implicit-function-declaration]
48 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_log_format
> security/integrity/integrity_audit.c:48:10: warning: assignment
to 'struct audit_context *' from 'int' makes pointer from integer without
a cast [-Wint-conversion]
48 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
--
In file included from security/integrity/ima/ima.h:22,
from security/integrity/ima/ima_api.c:18:
include/linux/audit.h:571:1: error: expected identifier or '(' before
'+' token
571 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
security/integrity/ima/ima_api.c: In function 'ima_audit_measurement':
security/integrity/ima/ima_api.c:362:12: error: implicit declaration of function
'audit_alloc_for_lsm'; did you mean 'audit_log_format'?
[-Werror=implicit-function-declaration]
362 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^~~~~~~~~~~~~~~~~~~
| audit_log_format
> security/integrity/ima/ima_api.c:362:10: warning: assignment to
'struct audit_context *' from 'int' makes pointer from integer without a
cast [-Wint-conversion]
362 | context = audit_alloc_for_lsm(GFP_KERNEL);
| ^
cc1: some warnings being treated as errors
vim +393 kernel/audit.c
385
386 static int audit_log_config_change(char *function_name, u32 new, u32 old,
387 int allow_changes)
388 {
389 struct audit_context *context;
390 struct audit_buffer *ab;
391 int rc = 0;
392
393 context = audit_alloc_for_lsm(GFP_KERNEL);
394 ab =
audit_log_start(context, GFP_KERNEL, AUDIT_CONFIG_CHANGE);
395 if (unlikely(!ab))
396 return rc;
397 audit_log_format(ab, "op=set %s=%u old=%u ", function_name, new, old);
398 audit_log_session_info(ab);
399 rc = audit_log_task_context(ab);
400 if (rc)
401 allow_changes = 0; /* Something weird, deny request */
402 audit_log_format(ab, " res=%d", allow_changes);
403 audit_log_end(ab);
404 audit_free_local(context);
405 return rc;
406 }
407
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org