Re: [PATCH 05/22] audit: Fix sleep in atomic
On Tue 03-01-17 16:11:16, Paul Moore wrote:
On Mon, Jan 2, 2017 at 1:21 PM, Jan Kara <jack(a)suse.cz> wrote:
> So I found where the problem was. Attached is a new version of the patch.
> Tests from audit-testsuite fail for me but do not hang anymore. I guess the
> failing is because I don't have audit or selinux configured in any way and
> I'm using SUSE I guess (if there's some easy way to do that, I'd be
> interested) - runtests.pl complains that I have to be root although I am...
I've never tried running the tests on SUSE, but if audit and SELinux
are in some undetermined state, then I can only imagine what wierd
test results you would get.
Well, the state is well determined - nothing is installed ;) I was kind of
hoping kernel support would be enough but apparently the testsuite needs
some userspace installed & configured as well.
I'm building a test kernel as I type this, I'll report back
when I have
some results.
Thanks!
Also, while I'm sure you've heard this before (and likely
already know
better), please send patches inline, it makes review/commenting much
easier.
Actually, I haven't heard this for quite a long time :) and I myself
prefer attached patches (with text/plain attachment type) when they are
in a reply to another email - they are easier to extract and at least my
mail client automatically inlines them when I hit reply... Arguably the
best of both worlds is to use git-send-email with properly set threading
but I tend to forget about that option.
Honza
--
Jan Kara <jack(a)suse.com>
SUSE Labs, CR