Re: [PATCH]: unreachable code block in auditd-sendmail.c
On Tuesday 08 November 2005 16:49, Dustin Kirkland wrote:
There appears to be some error handling deadcode in
src/auditd-sendmail.c. If fd<0, then the function returns and the error
handling code is never reached.
Thanks for finding this. The fix is not quite what you had:
fd = safe_popen(&pid, mail_acct);
- if (fd < 0)
- return 1;
- mail = fdopen(fd, "w");
if (fd < 0) {
The last "if" statement sb checking for mail == NULL. I'll fix this.
Thanks,
-Steve