Re: [PATCH ghak21 V2 2/4] audit: link denied should not directly generate PATH record

On 2018-03-12 11:05, Paul Moore wrote: > On Mon, Mar 12, 2018 at 2:31 AM, Richard Guy Briggs <rgb(a)redhat.com&gt; wrote: > > Audit link denied events generate duplicate PATH records which disagree > > in different ways from symlink and hardlink denials. > > audit_log_link_denied() should not directly generate PATH records. > > While we're at it, remove the now useless struct path argument. > > > > See: https://github.com/linux-audit/audit-kernel/issues/21 > > Signed-off-by: Richard Guy Briggs <rgb(a)redhat.com&gt; > > --- > > fs/namei.c | 2 +- > > include/linux/audit.h | 6 ++---- > > kernel/audit.c | 17 ++--------------- > > 3 files changed, 5 insertions(+), 20 deletions(-) > > I have no objection to the v2 change of removing the link parameter, > but this patch can not be merged as-is because the v1 patch has > already been merged into audit/next (as stated on the mailing list). Yes, I self-NACKed that patch. https://www.redhat.com/archives/linux-audit/2018-March/msg00070.html Is it not possible to drop it, or would you have to do a revert to avoid a rebase?