Re: [RFC][PATCH] (#6 U1) the latest incarnation
On Thursday 24 March 2005 04:02 pm, Timothy R. Chavez wrote:
On Thursday 24 March 2005 10:28 am, Stephen Smalley wrote:
> On Wed, 2005-03-23 at 14:22 -0600, Timothy R. Chavez wrote:
> > This is the latest patch.
>
> Other comments:
>
> - As it stands with your patch, alloc_inode() will leak memory if
> audit_inode_alloc() succeeds but security_inode_alloc() fails because
> nothing frees the audit data on the error handling path for that case.
I took your advice on just initializing inode->i_audit to NULL like the
security field. So would this be reasonable Stephen?
if (audit_inode_free(inode) || security_inode_alloc(inode)) {
Errr audit_inode_alloc(inode)... man... I'm going to quit writing e-mail for
the remainder of the day... I think I've done enough damage to my reputation
for the time being:-)
-tim