Re: [RFC][PATCH] (#2) Prelim in-kernel file system auditing support
Very minor nit: Define a static inline for audit_inode_alloc() and
use
it in alloc_inode(), and eliminate the #ifdef's there (and in
destroy_inode). You can just define them to the empty function in your
header file if the config option isn't set. Also, static inlines are
preferred to macros because they apply type checking even when the
option is disabled. Documentation/SubmittingPatches, Section 2.
Stephen,
I personally think this is a better way of doing it. I'll make the
change barring any objections from Chris, David, or Serge. The
audit_inode_alloc() will only allocate space for an inode its
associated with a "watched" location.
--
Stephen Smalley <sds(a)epoch.ncsc.mil>
National Security Agency
--
- Timothy R. Chavez