Re: [PATCH 1/9] Task Watchers v2: Task watchers v2

I can certainly change this. In my defense I didn't capitalize it because very similar macros in init.h were not capitalized. For example: #define core_initcall(fn) __define_initcall("1",fn) #define postcore_initcall(fn) __define_initcall("2",fn) #define arch_initcall(fn) __define_initcall("3",fn) #define subsys_initcall(fn) __define_initcall("4",fn) #define fs_initcall(fn) __define_initcall("5",fn) #define device_initcall(fn) __define_initcall("6",fn) #define late_initcall(fn) __define_initcall("7",fn) setup_param, early_param, module_init, etc. do not use all-caps. And I'm sure that's not all.

All of these declare variables and assign them attributes and values. > Looking at it now could you do something like, > > static int __task_watcher_init > audit_alloc(unsigned long val, struct task_struct *tsk) > > Instead of a macro? Might be a little less invasive. I like your suggestion. However, I don't see how such a macro could be made to replace the current macro. I need to be able to call every init function during task initialization. The current macro creates and initializes a function pointer in an array in the special ELF section. This allows the notify_task_watchers function to traverse the array and make calls to the init functions.