Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

On 12/11/2013 06:47 AM, Richard Guy Briggs wrote: > On Tue, Sep 03, 2013 at 02:31:59PM -0400, Richard Guy Briggs wrote: >> On Fri, Aug 30, 2013 at 01:37:09PM -0700, John Johansen wrote: >>> On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: >>>> On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nesterov wrote: >>>>> On 08/20, Richard Guy Briggs wrote: >>>> Most of the instances are current, but the one called from apparmour is >>>> stored. I've just learned that this is bad and someone else just chimed >>>> in that they have a patch to remove it... >>> >>> the apparmor case isn't actually stored long term. The stored task will be >>> a parameter that was passed into an lsm hook and the buffer that it is >>> stored in dies before the hook is done. Its temporarily stored in the >>> struct so that it can be passed into the lsm_audit fn, and printed into an >>> allocated audit buffer. The text version in the audit buffer is what will >>> exist beyond the hook. >>> >>> There are three patches, I'll reply them below once I have finished rebasing >>> them to apply to the current tree instead of my dev tree. >> >> John, thanks for this context and fix. That helps simplify things. > > John, What's the status of this set of 3 patches? I don't see them > upstream. > they are part of the security tree merge in 3.13 51775fe apparmor: remove the "task" arg from may_change_ptraced_domain() 4a7fc30 apparmor: remove parent task info from audit logging 61e3fb8 apparmor: remove tsk field from the apparmor_audit_struct dd0c6e8 apparmor: fix capability to not use the current task, during reporting