Re: [RFC][PATCH] (#4) auditfs

I'd not submit something with known glaring issues, so whether it's the fixed #4 (intermdiary or whatever), or #5, at least make sure it's as clean as possible. I'd also make sure that locking is correct, and that you've cared for refcounting things properly in the case of umount, for example (IOW, look out for the things that inotify got wrong). Perhaps one thing that would help is a succinct explanation of why inotify is insufficient, because with dnotify being marginal functional yet merged, inotify being worked on and this, all overlapping, the obvious questions will be around consolidating work. In fact, something that clearly states the requirements would be a good starting point. Sorry I haven't had much time to review this lately ;-(

thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net