Re: [PATCH ALT4 V3 1/2] audit: show fstype:pathname for entries with anonymous parents

On Thursday, November 9, 2017 3:52:46 PM EST Richard Guy Briggs wrote: > > >> > It might be simplest to just apply a corrective patch over top of > > >> > this one so that you don't have to muck about with git branches and > > >> > commit messages. > > >> > > >> A quick note on the "corrective patch": given we are just days away > > >> from the merge window opening, it is *way* to late for something like > > >> that, at this point the only options are to leave it as-is or > > >> yank/revert and make another pass during the next development phase. > > > > > > Then yank it. I think that is overreacting but given the options you > > > presented its the only one that avoids changing a critical field > > > format. > > > > It's not overreacting Steve, there is simply no way we can test and > > adequately soak new changes in the few days we have left. Its just moving the output of the information a few lines down further in the code. 10 minutes of work, tops.

> > Event yanks/reverts carry a risk at this stage, but I consider that the > > less risky option for these patches. Neither is a great option, and that > > is why I'm rather annoyed. > > I don't really see that this is my choice to include it or not. This is > the upstream maintainer's decision. > > I can't say I'd be thrilled to have my name on something that stuffs up > the system though. It still isn't clear to me why an incomplete path > from some seemingly random place in the filesystem tree is preferable to > something that gives it an anchor point, at least to human interpreters. The path should stay. Just the file system type needs decoupling and moving.