Re: patch update to ~51
On Wed, 2005-06-01 at 16:30 -0500, Timothy R. Chavez wrote:
@@ -2071,12 +2080,13 @@ int vfs_rename_dir(struct inode *old_dir
d_rehash(new_dentry);
dput(new_dentry);
}
- if (!error) {
+ if (!error)
d_move(old_dentry,new_dentry);
- audit_notify_watch(old_dentry->d_inode, MAY_WRITE);
+
+ error = audit_notify_watch(old_dentry->d_inode, MAY_WRITE);
+ if (!error)
security_inode_post_rename(old_dir, old_dentry,
new_dir, new_dentry);
- }
return error;
}
The operation has already happened. If audit_notify_watch() fails here,
you can't just pretend it didn't. Should we preallocate?
--
dwmw2