Re: the format string of printf to print audit status is wrong

Hello Steve, all audit status's type is __u32, so '%u' should be used in format string of printf rather than '%d', otherwise the value outputted to user will be wraparound. For example: # auditctl -r 4294967295 AUDIT_STATUS: enabled=1 flag=1 pid=8999 rate_limit=-1 backlog_limit=320 lost=2241 backlog=0 but it should be # auditctl -r 4294967295 AUDIT_STATUS: enabled=1 flag=1 pid=8999 rate_limit=4294967295 backlog_limit=320 lost=2270 backlog=0 This is the patch. Can you apply it? Signed-off-by: Yu Zhiguo<yuzg(a)cn.fujitsu.com> --- src/auditctl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/auditctl.c b/src/auditctl.c index d740509..5416e9b 100644 --- a/src/auditctl.c +++ b/src/auditctl.c @@ -1349,8 +1349,8 @@ static int audit_print_reply(struct audit_reply *rep) printed = 1; return 0; case AUDIT_GET: - printf("AUDIT_STATUS: enabled=%d flag=%d pid=%d" - " rate_limit=%d backlog_limit=%d lost=%d backlog=%d\n", + printf("AUDIT_STATUS: enabled=%u flag=%u pid=%u" + " rate_limit=%u backlog_limit=%u lost=%u backlog=%u\n",