Re: [PATCH v2] semanage: handle getprotobyname() failure case

On Mon, Jun 8, 2020 at 12:18 PM Stephen Smalley <stephen.smalley.work(a)gmail.com&gt; wrote: > > On Fri, Jun 5, 2020 at 4:24 AM Topi Miettinen <toiwoton(a)gmail.com&gt; wrote: > > > > At least on Debian, /etc/protocols, which is used by > > socket.getprotobyname() to resolve protocols to names, does not > > contain an entry for "ipv4". In that case, set the protocol number > > used by audit logs for "ipv4" to a fixed value. To ensure audit log > > compatibility, let's use the same numeric value as Fedora: 4, which is > > actually understood by kernel as IP over IP. > > > > Signed-off-by: Topi Miettinen <toiwoton(a)gmail.com&gt; > > This looks fine to me but adding linux-audit mailing list to see if > they have any concerns. It appears to make no change to the audit > messages on Fedora. Seeing no objections from linux-audit, Acked-by: Stephen Smalley <stephen.smalley.work(a)gmail.com&gt;