* Herbert Xu (herbert(a)gondor.apana.org.au) wrote:
Guys, please CC netdev on issues like this.
Sorry Herbert, we hadn't yet concluded that it's not an issue that we
need to resolve within audit.
On Tue, May 17, 2005 at 05:43:00PM +0000, Chris Wright wrote:
>
> This has some issues w.r.t. truesize and socket buffer space. The trim
> is done to keep accounting sane, so we'd either have to trim ourselves
> or take into account the change in size. And ultimately, we'd still get
> trimmed by netlink, so the GFP issue is still there. Ideally, gfp_any()
> would really be _any_
The trimming is completely optional. That is, if the allocation fails
nothing bad will happen. So the solution is to simply use GFP_ATOMIC.
Well, it does more pressure on atomic pool (for those cases that
GFP_KERNEL would have sufficed).
thanks,
-chris