Re: [PATCHv2 1/2] mm: introduce get_task_exe_file

On 08/23, Mateusz Guzik wrote: > > +struct file *get_task_exe_file(struct task_struct *task) > +{ > + struct file *exe_file = NULL; > + struct mm_struct *mm; > + > + task_lock(task); > + mm = task->mm; > + if (mm) { > + if (!(task->flags & PF_KTHREAD)) > + exe_file = get_mm_exe_file(mm); > + } > + task_unlock(task); > + return exe_file; > +} I can't believe I am going to comment the coding style but I can't resist ;) if (mm && !(task->flags & PF_KTHREAD))) exe_file = get_mm_exe_file(mm); looks a bit simpler to me. But this is purely cosmetic and subjective, both patches look good to me.

Acked-by: Oleg Nesterov <oleg(a)redhat.com&gt;