Re: [RFC][PATCH] collect security labels on user processes generating audit messages

> +u32 selinux_task_getsecid(struct task_struct *tsk) > +{ > + u32 sid = 0; > + > + if (ss_initialized) > + sid = ((struct task_security_struct *)tsk->security)->sid; > + > + return sid; > +} You don't strictly need to check ss_initialized in this function; all tasks are assigned the kernel SID until policy is loaded, so you can always access the SID. As a matter of style, I'd prefer an explicit task_security_struct* local variable with separate assignment, i.e. struct task_security_struct *tsec = tsk->security; sid = tsec->sid;