Re: [PATCH 1/2] audit: fix NUL handling in untrusted strings

Miloslav Trmač wrote: Yes, that's correct. However, the function in question, audit_log_n_untrustedstring() is not an interface accepting a null terminated string, it accepts a count. The helper function on which it is dependent, audit_string_contains_control(), disregards the length parameter it is passed and thus audit_log_n_untrustedstring() misbehaves as a consequence. This is true, but it's only part of the problem, the string functions still need to be robust, even used inappropriately. -- John Dennis <jdennis(a)redhat.com&gt;