Re: [PATCH v2] audit: report audit wait metric in audit status reply
On Thursday, December 3, 2020 6:43:11 PM EST Paul Moore wrote:
> So far there are only seven bits used out of 32, so it does not
appear we
> are in danger of running out anytime soon.
Exactly. Even capability bits are easier to get assigned. :-)
> It was introduced with commit
0288d7183c41c0192d2963d44590f346f4aee917
> Author: Richard Guy Briggs <rgb(a)redhat.com>
> AuthorDate: 2014-11-17 15:51:01 -0500
> Commit: Paul Moore <pmoore(a)redhat.com>
> CommitDate: 2014-11-17 16:53:51 -0500
> ("audit: convert status version to a feature bitmap")
> It was introduced specifically to enable distributions to selectively
> backport features. It was converted away from AUDIT_VERSION.
>
> There are other ways to detect the presence of backlog_wait_time_actual
> as I mentioned above.
Let me be blunt - I honestly don't care what Steve's audit userspace
does to detect this. I've got my own opinion, but Steve's audit
userspace is not my project to manage and I think we've established
over the years that Steve and I have very different views on what
constitutes good design.
And guessing what might be in buffers of different sizes is good design? The
FEATURE_BITMAP was introduced to get rid of this ambiguity.
-Steve