Re: [RFC][PATCH] add security label to user messages

On Friday 13 January 2006 19:49, Timothy R. Chavez wrote: > @@ -464,6 +468,13 @@ static int audit_receive_msg(struct sk_b > "user pid=%d uid=%u > auid=%u msg='%.1024s'", pid, uid, loginuid, (char *)data); > audit_set_pid(ab, pid); > + read_lock(&tasklist_lock); > + tsk = find_task_by_pid(pid); Looks good except...netlink is an async protocol. The pid that sent the netlink packet may have been replaced by another process with the same pid by the time we receive the packet. Seems like we need to collect and use the sid at send time just like we do the loginuid. -Steve