Re: Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit test fix for exec arg len
On Sunday, July 12, 2015 03:11:09 AM Mustapha Abiola wrote:
From 55fae099d46749b73895934aab8c2823c5a23abe Mon Sep 17 00:00:00
2001
From: Mustapha Abiola <hi(a)mustapha.org>
Date: Sat, 11 Jul 2015 17:01:04 +0000
Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken
audit test fix for exec arg len
Quick patch to fix the needless check of `len` being < 0 as its an
unsigned int.
Signed-off-by: Mustapha Abiola <hi(a)mustapha.org>
---
kernel/auditsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thank you for the patch, but it appears your mail client has mangled the patch
so it does not apply cleanly. As a general rule, you should be able to save
the email and apply it directly to the tree; if not, you are doing something
wrong.
Have you read the notes in the Documentation/SubmittingPatches file, yet? If
not, I suggest taking a look, there is a lot of good information there on
submitting patches to the mailing list.
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index e85bdfd..0012476 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1021,7 +1021,7 @@ static int audit_log_single_execve_arg(struct
audit_context *context,
* for strings that are too long, we should not have created
* any.
*/
- if (WARN_ON_ONCE(len < 0 || len > MAX_ARG_STRLEN - 1)) {
+ if (WARN_ON_ONCE(len > MAX_ARG_STRLEN - 1)) {
send_sig(SIGKILL, current, 0);
return -1;
}
--
paul moore
www.paul-moore.com