Re: Format specifier issue when building kernel

On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: > On Mon, Oct 28, 2013 at 4:30 PM, William Roberts > <bill.c.roberts(a)gmail.com&gt;wrote: > > > I've been working off of Richard Guy Brigs git repo on branch > > audit-for-next prepping my patch and I noticed a build warning: > > > > kernel/audit.c:832:8: warning: format ‘%A’ expects argument of type > > ‘double’, but argument 3 has type ‘char *’ [-Wformat] > > > > Looking at the code, it looks wrong: > > > > audit_log_format(ab, > " > msg='%.AUDIT_MESSAGE_TEXT_MAXs'", > (char *)data); > > The issue appears on the % specifier in there, it picks it up as %.A, which > is of type double. Is this what was intended? Hmmm, that should have picked up a macro from 06051fbe in audit-for-next. It should be pre-processed to "%.8560s". > William C Roberts - RGB

-- Richard Guy Briggs <rbriggs(a)redhat.com&gt; Senior Software Engineer Kernel Security AMER ENG Base Operating Systems Remote, Ottawa, Canada Voice: +1.647.777.2635 Internal: (81) 32635 Alt: +1.613.693.0684x3545