Re: [PATCH v31 26/28] Audit: Add record for multiple object security contexts

Hi Casey, I love your patch! Yet something to improve: [auto build test ERROR on nf-next/master] [cannot apply to pcmoore-audit/next nf/master linus/master jmorris-security/next-testing v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/integrity-disass... base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20211214/202112142146.BpckyASr-lk...) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2a62f660ff9d766a192fda713edfa3ea1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20211214-084057 git checkout 2a62f660ff9d766a192fda713edfa3ea129efdee # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from init/init_task.c:12: 262 | { } | ^ include/linux/audit.h:260:20: warning: 'audit_log_object_context' declared 'static' but never defined [-Wunused-function] 260 | static inline void audit_log_object_context(struct audit_buffer *ab, | ^~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from kernel/exit.c:49: 262 | { } | ^ kernel/exit.c:1817:13: warning: no previous prototype for 'abort' [-Wmissing-prototypes] 1817 | __weak void abort(void) | ^~~~~ In file included from kernel/exit.c:49: include/linux/audit.h:260:20: warning: 'audit_log_object_context' declared 'static' but never defined [-Wunused-function] 260 | static inline void audit_log_object_context(struct audit_buffer *ab, | ^~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from fs/pipe.c:23: 262 | { } | ^ fs/pipe.c:755:15: warning: no previous prototype for 'account_pipe_buffers' [-Wmissing-prototypes] 755 | unsigned long account_pipe_buffers(struct user_struct *user, | ^~~~~~~~~~~~~~~~~~~~ fs/pipe.c:761:6: warning: no previous prototype for 'too_many_pipe_buffers_soft' [-Wmissing-prototypes] 761 | bool too_many_pipe_buffers_soft(unsigned long user_bufs) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:768:6: warning: no previous prototype for 'too_many_pipe_buffers_hard' [-Wmissing-prototypes] 768 | bool too_many_pipe_buffers_hard(unsigned long user_bufs) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:775:6: warning: no previous prototype for 'pipe_is_unprivileged_user' [-Wmissing-prototypes] 775 | bool pipe_is_unprivileged_user(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:1245:5: warning: no previous prototype for 'pipe_resize_ring' [-Wmissing-prototypes] 1245 | int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots) | ^~~~~~~~~~~~~~~~ In file included from fs/pipe.c:23: include/linux/audit.h:260:20: warning: 'audit_log_object_context' declared 'static' but never defined [-Wunused-function] 260 | static inline void audit_log_object_context(struct audit_buffer *ab, | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +262 include/linux/audit.h 220 221 #else /* CONFIG_AUDIT */ 222 static inline __printf(4, 5) 223 void audit_log(struct audit_context *ctx, gfp_t gfp_mask, int type, 224 const char *fmt, ...) 225 { } 226 static inline struct audit_buffer *audit_log_start(struct audit_context *ctx, 227 gfp_t gfp_mask, int type) 228 { 229 return NULL; 230 } 231 static inline __printf(2, 3) 232 void audit_log_format(struct audit_buffer *ab, const char *fmt, ...) 233 { } 234 static inline void audit_log_end(struct audit_buffer *ab) 235 { } 236 static inline void audit_log_n_hex(struct audit_buffer *ab, 237 const unsigned char *buf, size_t len) 238 { } 239 static inline void audit_log_n_string(struct audit_buffer *ab, 240 const char *buf, size_t n) 241 { } 242 static inline void audit_log_n_untrustedstring(struct audit_buffer *ab, 243 const char *string, size_t n) 244 { } 245 static inline void audit_log_untrustedstring(struct audit_buffer *ab, 246 const char *string) 247 { } 248 static inline void audit_log_d_path(struct audit_buffer *ab, 249 const char *prefix, 250 const struct path *path) 251 { } 252 static inline void audit_log_key(struct audit_buffer *ab, char *key) 253 { } 254 static inline void audit_log_path_denied(int type, const char *operation) 255 { } 256 static inline int audit_log_task_context(struct audit_buffer *ab) 257 { 258 return 0; 259 } 260 static inline void audit_log_object_context(struct audit_buffer *ab, 261 struct lsmblob *blob); 263 static inline void audit_log_task_info(struct audit_buffer *ab) 264 { } 265 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org