Re: [RESEND PATCH 1/2] audit: change unnecessary globals into statics

On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge <jbi.octave(a)gmail.com&gt; wrote: > > Variables sig_pid, audit_sig_uid and audit_sig_sid > are only used in the audit.c file across the kernel > Hence it appears no reason for declaring them as globals > This patch removes their global declarations from the .h file > and change them into static in the .c file. > > Signed-off-by: Jules Irenge <jbi.octave(a)gmail.com&gt; > --- > kernel/audit.c | 6 +++--- > kernel/audit.h | 4 ---- > 2 files changed, 3 insertions(+), 7 deletions(-) Thanks Jules, this looks reasonable although I'm not going to merge them into audit/next until after the merge window closes. I'll send another reply once this has been merged.