Re: [RFC PATCH v5 05/11] fs: add security blob and hooks for block_device
On 7/28/2020 3:40 PM, Al Viro wrote:
On Tue, Jul 28, 2020 at 03:22:59PM -0700, Casey Schaufler wrote:
>> + hlist_for_each_entry(p, &security_hook_heads.bdev_setsecurity, list) {
>> + rc = p->hook.bdev_setsecurity(bdev, name, value, size);
>> +
>> + if (rc == -ENOSYS)
>> + rc = 0;
>> +
>> + if (rc != 0)
>
> Perhaps:
> else if (rc != 0)
>
>> + break;
>> + }
>> +
>> + return rc;
hlist_for_each_entry(p, &security_hook_heads.bdev_setsecurity, list) {
rc = p->hook.bdev_setsecurity(bdev, name, value, size);
if (rc && rc != -ENOSYS)
return rc;
}
return 0;
Easier to reason about that way...
Yeah, this is cleaner. I'll make the change for v6.