Re: [RFC][PATCH] (#6) filesystem auditing
On Fri, 2005-03-18 at 14:41 -0500, Stephen Smalley wrote:
- Is there any reason to use the irqsave/irqrestore form of the
locks?
When is your code ever called from irq?
- Relying on locking in the caller to protect your own data structures
seems fragile and unmaintainable; I don't think you want to rely on the
caller holding dentry->d_lock for exclusion for your own lists, e.g. the
audit data stack?
Sorry, I meant dcache_lock here, not dentry->d_lock, as that would
obviously be completely broken.
--
Stephen Smalley <sds(a)tycho.nsa.gov>
National Security Agency