Re: [PATCH] i386/audit: stop scribbling on the stack frame
On 10/27/2014 06:55 AM, Eric Paris wrote:
My patch was already committed to the -tip urgent branch. I believe
any
optimization should be based on that branch, Richard. If you are trying
to wrangle every bit of speed out of this, should you
push %esi;
push %edi;
CFI_ADJUST_CFA_OFFSET 8
call __audit_syscall_entry
pop;
pop;
CFI_ADJUST_CFA_OFFSET -8
Instead of using the pushl_cfi and popl_cfi macros?
I wrote my patch to be obviously correct, but agree there are certainly
some speedups possible.
Uh... not only is that plain wrong (the CFI should be adjusted after
each instruction that changes the stack pointer), but what the heck is
wrong with using the macros?
-hpa