Re: [PATCH]: unreachable code block in auditd-sendmail.c
On Tue, 08 Nov 2005 15:49:02 CST, Dustin Kirkland said:
fd = safe_popen(&pid, mail_acct);
- if (fd < 0)
- return 1;
- mail = fdopen(fd, "w");
if (fd < 0) {
Alternatively, is it possible the second 'if' should have read
'if (mail < 0) {' to check the return code from the fdopen()?
Your patch doesn't check for an fdopen() failure.
Attachments:
- attachment.sig (application/pgp-signature — 226 bytes)