errormsg table macros [was: Re: [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes]

On 2017-05-04 16:49, Steve Grubb wrote: > On Thursday, May 4, 2017 4:29:45 PM EDT Richard Guy Briggs wrote: > > On 2017-05-04 16:11, Steve Grubb wrote: > > > Was there a patch in this series that converted errormsg.h to use the > > > macros? > > I don't quite follow. Can you give a fictional example off the top of > > your head of what you are hoping for? > > This table: > > static const struct msg_tab err_msgtab[] = { > { -1, 2, "-F missing operation for" }, > { -2, 2, "-F unknown field:" }, > { -3, 1, "must be before -S" }, > { -4, 1, "machine type not found" }, > ... > > converted to using the defines. The libaudit return codes were fixed to > defines. But the table the return codes are looked up in is still using > numbers. Ah, got it, yes, completely agree.

> -Steve - RGB