Re: [PATCH V10] fixup! audit: add audit by children of executable path

Adding "C=1 CF=-D__CHECK_ENDIAN__" to enable sparse warnings identified a warning with the [PATCH V9 3/3] audit: add audit by children of executable path patch posted a couple of days ago (and just re-posted due to another fix): kernel/auditsc.c:476:46: warning: dereference of noderef expression kernel/auditsc.c:477:61: warning: dereference of noderef expression task_struct->parent requires RCU locking for access. This fix resolves the two warnings. This patch should be merged with the patch it fixes once the fix is confirmed to be the correct approach since the original patch hasn't been accepted yet. Signed-off-by: Richard Guy Briggs <rgb(a)redhat.com&gt; --- My hesitation is that the rcu lock scope is too broad. If the loop were re-structured to hold the rcu_read_lock() and call rcu_dereference() once per iteration, would lock release and retake action cause more overhead? kernel/auditsc.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/kernel/auditsc.c b/kernel/auditsc.c index e1f0da2..3ed043d 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -473,13 +473,16 @@ static int audit_filter_rules(struct task_struct *tsk, { struct task_struct *ptsk; - for (ptsk = tsk; ptsk->parent->pid > 0; - ptsk = find_task_by_pid_ns(ptsk->parent->pid, &init_pid_ns)) { + rcu_read_lock(); + for (ptsk = tsk; rcu_dereference(ptsk->parent)->pid > 0; + ptsk = find_task_by_pid_ns(rcu_dereference(ptsk->parent)->pid + , &init_pid_ns)) { if (audit_exe_compare(ptsk, rule->exe)) { ++result; break; } } + rcu_read_unlock(); } break; case AUDIT_UID: