Re: [PATCH 5/8] integrity: Add exe= and tty= before res= to integrity audits

On Thu, May 24, 2018 at 4:11 PM, Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; wrote: > Use the new public audit functions to add the exe= and tty= > parts to the integrity audit records. We place them before > res=. > > Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; > Suggested-by: Steve Grubb <sgrubb(a)redhat.com&gt; > --- > security/integrity/integrity_audit.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c > index db30763d5525..8d25d3c4dcca 100644 > --- a/security/integrity/integrity_audit.c > +++ b/security/integrity/integrity_audit.c > @@ -56,6 +56,8 @@ void integrity_audit_msg(int audit_msgno, struct inode *inode, > audit_log_untrustedstring(ab, inode->i_sb->s_id); > audit_log_format(ab, " ino=%lu", inode->i_ino); > } > + audit_log_d_path_exe(ab, current->mm); > + audit_log_tty(ab, current); NACK Please add the new fields to the end of the audit record, thank you.

> audit_log_format(ab, " res=%d", !result); > audit_log_end(ab); > }