Re: [PATCH] audit: tame initialization warning len_abuf in audit_log_execve_info

On Thu, Nov 10, 2016 at 1:39 AM, Richard Guy Briggs <rgb(a)redhat.com&gt; wrote: > Tame initialization warning of len_abuf in audit_log_execve_info even > though there isn't presently a bug introduced by commit 43761473c254 > ("audit: fix a double fetch in audit_log_single_execve_arg()"). Using > UNINITIALIZED_VAR instead may mask future bugs. > > Signed-off-by: Richard Guy Briggs <rgb(a)redhat.com&gt; > --- > kernel/auditsc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Compiler warnings are annoying, regardless of if they are actually problems or not so I'm going to merge this ... although I'm pretty sure in a year or two somebody is going to submit a one-liner removing this because it's unnecessary :)

> diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index e414dfa..d161b17 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -1000,7 +1000,7 @@ static void audit_log_execve_info(struct audit_context *context, > long len_rem; > long len_full; > long len_buf; > - long len_abuf; > + long len_abuf = 0; > long len_tmp; > bool require_data; > bool encode;