Re: [PATCH] selinux: print leading 0x on ioctlcmd audits
On Thu, Jul 14, 2016 at 3:29 PM, <william.c.roberts(a)intel.com> wrote:
From: William Roberts <william.c.roberts(a)intel.com>
ioctlcmd is currently printing hex numbers, but their is no leading
0x. Thus things like ioctlcmd=1234 are misleading, as the base is
not evident.
Correct this by adding 0x as a prefix, so ioctlcmd=1234 becomes ioctlcmd=0x1234.
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
---
security/lsm_audit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
NOTE: adding Steve Grubb and the audit mailing list to the CC line
Like it or not, I believe the general standard/convention when it
comes to things like this is to leave off the "0x" prefix; the idea
being that is saves precious space in the audit logs and the value is
only ever going to be in hex anyway.
diff --git a/security/lsm_audit.c b/security/lsm_audit.c
index cccbf30..82e4dbb 100644
--- a/security/lsm_audit.c
+++ b/security/lsm_audit.c
@@ -257,7 +257,7 @@ static void dump_common_audit_data(struct audit_buffer *ab,
audit_log_format(ab, " ino=%lu", inode->i_ino);
}
- audit_log_format(ab, " ioctlcmd=%hx", a->u.op->cmd);
+ audit_log_format(ab, " ioctlcmd=0x%hx", a->u.op->cmd);
break;
}
case LSM_AUDIT_DATA_DENTRY: {
--
1.9.1
_______________________________________________
Selinux mailing list
Selinux(a)tycho.nsa.gov
To unsubscribe, send email to Selinux-leave(a)tycho.nsa.gov.
To get help, send an email containing "help" to Selinux-request(a)tycho.nsa.gov.
--
paul moore
www.paul-moore.com