On 14/01/24, Peter Zijlstra wrote:
On Fri, Jan 24, 2014 at 01:14:47AM -0500, Richard Guy Briggs wrote:
> On 14/01/23, Peter Zijlstra wrote:
> > On Thu, Jan 23, 2014 at 02:32:33PM -0500, Richard Guy Briggs wrote:
> > > These are a number of patches inspired by ebiederman's container work
that were
> > > included by me 2013-08-20 as the patchset:
> > > RFC: steps to make audit pid namespace-safe
> > >
> > > They have been seperated out for the pid maintainer since there are no
direct
> > > dependencies from the audit pid namespace patchset with the exception of:
> > > pid: get pid_t ppid of task in init_pid_ns
> > >
> > > Andrew, are you willing to adopt these?
> > >
> > > In particular, there is discussion around read-only task_struct::pid
here:
> > >
https://lkml.org/lkml/2013/12/16/552
> >
> > I would have ordered them slightly different, but:
>
> Can you briefly explain how and why so I can understand for next time?
> I originally had the ppid patch first...
Ah, I would have introduced CONST_CAST() earlier, then used it in the
make pid const and then avoided the conversion patch.
Ah, fair enough. It does serve to show how much ugliness can be avoided
though...
- RGB
--
Richard Guy Briggs <rbriggs(a)redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545