Re: [PATCH 09/14] nds32: define syscall_get_arch()

Dmitry V. Levin <ldv(a)altlinux.org&gt; 於 2019年2月27日 週三 下午11:30寫道： > > syscall_get_arch() is required to be implemented on all architectures > in addition to already implemented syscall_get_nr(), > syscall_get_arguments(), syscall_get_error(), and > syscall_get_return_value() functions in order to extend the generic > ptrace API with PTRACE_GET_SYSCALL_INFO request. > > Acked-by: Paul Moore <paul(a)paul-moore.com&gt; > Cc: Elvira Khabirova <lineprinter(a)altlinux.org&gt; > Cc: Eugene Syromyatnikov <esyr(a)redhat.com&gt; > Cc: Greentime Hu <green.hu(a)gmail.com&gt; > Cc: Vincent Chen <deanbo422(a)gmail.com&gt; > Cc: Oleg Nesterov <oleg(a)redhat.com&gt; > Cc: Andy Lutomirski <luto(a)kernel.org&gt; > Cc: linux-audit(a)redhat.com > Signed-off-by: Dmitry V. Levin <ldv(a)altlinux.org&gt; > --- > This is just a gentle ping, the patch is unchanged. > > arch/nds32/include/asm/syscall.h | 9 +++++++++ > include/uapi/linux/audit.h | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/arch/nds32/include/asm/syscall.h b/arch/nds32/include/asm/syscall.h > index f7e5e86765fe..cc56a3962f8b 100644 > --- a/arch/nds32/include/asm/syscall.h > +++ b/arch/nds32/include/asm/syscall.h > @@ -5,6 +5,7 @@ > #ifndef _ASM_NDS32_SYSCALL_H > #define _ASM_NDS32_SYSCALL_H 1 > > +#include <uapi/linux/audit.h> > #include <linux/err.h> > struct task_struct; > struct pt_regs; > @@ -185,4 +186,12 @@ void syscall_set_arguments(struct task_struct *task, struct pt_regs *regs, > > memcpy(&regs->uregs[0] + i, args, n * sizeof(args[0])); > } > + > +static inline int > +syscall_get_arch(void) > +{ > + return IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) > + ? AUDIT_ARCH_NDS32BE : AUDIT_ARCH_NDS32; > +} > + > #endif /* _ASM_NDS32_SYSCALL_H */ > diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h > index b1602dcc13bc..1568ddc1c945 100644 > --- a/include/uapi/linux/audit.h > +++ b/include/uapi/linux/audit.h > @@ -401,6 +401,8 @@ enum { > #define AUDIT_ARCH_MIPSEL64 (EM_MIPS|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) > #define AUDIT_ARCH_MIPSEL64N32 (EM_MIPS|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE|\ > __AUDIT_ARCH_CONVENTION_MIPS64_N32) > +#define AUDIT_ARCH_NDS32 (EM_NDS32|__AUDIT_ARCH_LE) > +#define AUDIT_ARCH_NDS32BE (EM_NDS32) > #define AUDIT_ARCH_OPENRISC (EM_OPENRISC) > #define AUDIT_ARCH_PARISC (EM_PARISC) > #define AUDIT_ARCH_PARISC64 (EM_PARISC|__AUDIT_ARCH_64BIT) > -- > ldv Thanks for fixing this. Acked-by Vincent Chen