Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
Paul,
Thanks for your review.
----- "Paul Moore" <paul.moore(a)hp.com> wrote:
There are several audit experts which should review this code but
two
things
jumped out at me when glancing at your patch:
1. SELinux SIDs should not be recorded
Almost all code that logs SELinux contexts
in kernel/audit* does the same thing as this patch, falling back to a SID if it can't
be converted to a string.
2. From a SELinux/security point of view ttys are considered
objects
and their labels/contexts should be recorded with "obj=" not
"subj="
The patch logs the context of the process, not of the TTY.
Mirek
Paul Moore
Friday, 20 March
Fri, 20 Mar
8:51 a.m.
New subject: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records
On Friday 20 March 2009 04:53:27 am Miloslav Trmac wrote:
----- "Paul Moore" <paul.moore(a)hp.com> wrote:
> There are several audit experts which should review this code but two
> things jumped out at me when glancing at your patch:
>
> 1. SELinux SIDs should not be recorded
Almost all code that logs SELinux contexts in kernel/audit* does the same
thing as this patch, falling back to a SID if it can't be converted to a
string.
Ungh, that's ugly and questionably useful (I suppose I know why this is done)
but if that convention then who am I to argue.
> 2. From a SELinux/security point of view ttys are considered
objects
> and their labels/contexts should be recorded with "obj=" not
> "subj="
The patch logs the context of the process, not of the TTY.
Okay, that is what I get for just glancing at patches and not looking at them
closer :)
--
paul moore
linux @ hp
5756
days inactive
5756
days old
linux-audit@lists.linux-audit.osci.io
1 comments
2 participants
tags (0)
participants (2)
-
Miloslav Trmac -
Paul Moore