Re: [PATCH 2/2] Fixed Trivial Warnings in file: Deleted Spaces prior to tabs, and added lines. modified: kernel/auditfilter.c

On 10/14/2015 04:54 PM, Paul Moore wrote: > On Saturday, October 10, 2015 08:57:55 PM Scott Matheina wrote: >> Signed-off-by: Scott Matheina <scott(a)matheina.com&gt; >> --- >> >> kernel/auditfilter.c | 17 ++++++++++------- >> 1 file changed, 10 insertions(+), 7 deletions(-) > > Sorry for the delay in reviewing this, comments inline ... > >> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c >> index 7714d93..774f9ad 100644 >> --- a/kernel/auditfilter.c >> +++ b/kernel/auditfilter.c >> @@ -39,13 +39,13 @@ >> >> * Locking model: >> * >> >> * audit_filter_mutex: >> - * Synchronizes writes and blocking reads of audit's filterlist >> - * data. Rcu is used to traverse the filterlist and access >> - * contents of structs audit_entry, audit_watch and opaque >> - * LSM rules during filtering. If modified, these structures >> - * must be copied and replace their counterparts in the filterlist. >> - * An audit_parent struct is not accessed during filtering, so may >> - * be written directly provided audit_filter_mutex is held. >> + * Synchronizes writes and blocking reads of audit's filterlist >> + * data. Rcu is used to traverse the filterlist and access >> + * contents of structs audit_entry, audit_watch and opaque >> + * LSM rules during filtering. If modified, these structures >> + * must be copied and replace their counterparts in the filterlist. >> + * An audit_parent struct is not accessed during filtering, so may >> + * be written directly provided audit_filter_mutex is held. >> >> */ > > Okay, that's fine.

As you might have guessed, this is one of my first patches. I wasn't sure if a patch like this would even get reviewed, and responded to. I'm subscribed to the linux-kernel mail group, and seeing what is acceptable. Thanks for the review. I don't plan on making a habit of submitting such incredibly trivial patches, but you have to start somewhere, and I thought it'd be hard to screw up by fixing a couple of trivial style errors.