Re: [PATCH] improved xfrm_audit_log() patch

On Tue, 2007-08-07 at 18:32 -0700, David Miller wrote: >From: Joy Latten <latten(a)austin.ibm.com&gt; >Date: Thu, 2 Aug 2007 15:56:47 -0500 > >> @@ -426,10 +426,15 @@ struct xfrm_audit >> }; >> >> #ifdef CONFIG_AUDITSYSCALL >> -extern void xfrm_audit_log(uid_t auid, u32 secid, int type, int result, >> - struct xfrm_policy *xp, struct xfrm_state *x); >> +extern void xfrm_audit_log(struct xfrm_audit audit_info, int result, >> + __be32 flowid, struct xfrm_policy *xp, >> + struct xfrm_state *x, char *buf); > >Passing audit_info as an aggregate argument puts them into >previous argument registers, or if they are not enough it >goes either partially of wholly onto the stack, depending >upon architecture. > >In fact you've made the argument register usage worse than >in your previous revision. :-/ > >Perhaps you meant to pass "struct xfrm_audit *" instead? Revised patch to pass pointer to struct xfrm_audit. Sorry, I missed that. Signed-off-by: Joy Latten <latten(a)austin.ibm.com&gt;