Re: audit.82 kernel
On Sat, 2005-07-30 at 08:54 -0400, Steve Grubb wrote:
The patch didn't do anything for audit_data_get and that is now
showing up as
our current problem. Is there any chance of using a different lock scheme
that is lightweight for readers and heavier for writers? I feel that if we
can do something for this function, we've got the performance issues solved
for people that aren't using the audit system.
We could almost certainly get away with checking the common case
(!allocate && !(flags & I_AUDIT)) without actually taking the lock.
That ought to suffice, but I didn't want to make that change in the same
release as the other changes.
David, my patch differed a little from the one sent to the mail list:
<...>
This moves the unconditional zeroing into the path that keeps the
context.
That's the common case by far anyway. It'll make zero difference in the
profile, AFAICT. Let's not just move stuff around for the sake of it.
--
dwmw2