Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

audit_file() is related with AUDITSYSCALL, not related with AUDIT, so need move dummy one from !AUDIT area to !AUDITSYSCALL area. Or it will cause issue if CONFIG_AUDIT with !CONFIG_AUDITSYSCALL. The related error (with allmodconfig under tile): CC fs/open.o fs/open.c: In function 'SYSC_fchmod': fs/open.c:530:3: error: implicit declaration of function 'audit_file' [-Werror=implicit-function-declaration] audit_file(f.file); ^ Signed-off-by: Chen Gang <gang.chen.5i5j(a)gmail.com&gt; --- include/linux/audit.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/include/linux/audit.h b/include/linux/audit.h index 295ae1c..7b1d0d1 100644 --- a/include/linux/audit.h +++ b/include/linux/audit.h @@ -363,6 +363,8 @@ static inline void audit_inode(struct filename *name, const struct dentry *dentry, unsigned int parent) { } +static inline void audit_file(struct file *file) +{ } static inline void audit_inode_parent_hidden(struct filename *name, const struct dentry *dentry) { } @@ -538,9 +540,6 @@ static inline void audit_log_task_info(struct audit_buffer *ab, struct task_struct *tsk) { } #define audit_enabled 0 -static inline void audit_file(struct file *file) -{ -} #endif /* CONFIG_AUDIT */ static inline void audit_log_string(struct audit_buffer *ab, const char *buf) {