On Fri, Sep 30, 2022 at 1:45 PM Steve Grubb <sgrubb(a)redhat.com> wrote:
Hello,
Thanks for the detailed notes on this investigation. It really is a lot of
good information backing this up. However, there will come a day when someone
sees this "major = ctx->major" and they will send a patch to "fix"
this
unnecessary assignment. If you are sending a V2 of this set, I would suggest
adding some comment in the code that this is for a performance improvement
and to see the commit message for additional info.
Please do not send a v2 with the changes Steve is suggesting, I think
this patch is fine as-is.
--
paul-moore.com